Add Aaron's awesome talk to homepage and resource page #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchahinRohani
had a problem deploying
to
production
GitHub Actions
Failure
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
had a problem deploying
to
production
GitHub Actions
Failure
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
force-pushed
the
feature/aarons-awesome-talk
branch
from
e3a3b34 to
e443598
Compare
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
force-pushed
the
feature/aarons-awesome-talk
branch
from
e443598 to
952b58c
Compare
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
nit: consider adding it to the LRE readme https://www.nativelink.com/docs/explanations/lre
❤️
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
web/platform/src/components/qwik/pages/home.tsx line 19 at r2 (raw file):
<div class="mx-auto left-0 right-0 w-9/11 flex justify-center items-center flex-col gap-4"> <div class="text-sm flex justify-center w-full md:w-9/12 px-8 md:px-0"> An awesome talk of one of TraceMachina's leading engineers Aaron
nit: The text looks out of place on the homepage. Maybe let's just add the video without the text?
Add an iframe to the homepage and resource page linked to the the youtube video: "Hermetic Toolchain Creation with Local Remote Execution (LRE) & Nix" by Aaron Mondal, NativeLink
SchahinRohani
force-pushed
the
feature/aarons-awesome-talk
branch
from
952b58c to
e436edc
Compare
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Aaron Mondals awesome talk on the bazelcon to the homepage and resource page
Checklist
bazel test //...passes locallygit amendsee some docsThis change is